ghsa-prmv-7r8c-794g
Vulnerability from github
Summary
Short descriptions set via the ShortDescription extension are inserted as raw HTML by the Citizen skin, allowing any user to insert arbitrary HTML into the DOM by editing a page.
Details
The shortdesc
property, which contains unsanitized user input, is retrieved from the OutputPage and returned as the tagline:
https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/0d8a44011e02a081618359a1e90f462478e807aa/includes/Components/CitizenComponentPageHeading.php#L249-L251
The tagline is then provided to the template data:
https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/0d8a44011e02a081618359a1e90f462478e807aa/includes/Components/CitizenComponentPageHeading.php#L270-L275
The template then inserts the tagline into raw HTML without doing any escaping:
https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/0d8a44011e02a081618359a1e90f462478e807aa/templates/PageHeading.mustache#L12
PoC
- Enable Citizen and ShortDescription
- Add
{{SHORTDESC:<img src="" onerror="alert('citizen shortdescription xss')">}}
to a page - Visit the page
Impact
Arbitrary HTML can be inserted into the DOM by any user, allowing for JavaScript to be executed.
{ "affected": [ { "package": { "ecosystem": "Packagist", "name": "starcitizentools/citizen-skin" }, "ranges": [ { "events": [ { "introduced": "1.9.4" }, { "fixed": "3.4.0" } ], "type": "ECOSYSTEM" } ] } ], "aliases": [ "CVE-2025-53370" ], "database_specific": { "cwe_ids": [ "CWE-79" ], "github_reviewed": true, "github_reviewed_at": "2025-07-03T21:29:16Z", "nvd_published_at": "2025-07-03T20:15:23Z", "severity": "HIGH" }, "details": "### Summary\nShort descriptions set via the [ShortDescription extension](https://www.mediawiki.org/wiki/Extension:ShortDescription) are inserted as raw HTML by the Citizen skin, allowing any user to insert arbitrary HTML into the DOM by editing a page.\n\n### Details\nThe `shortdesc` property, which contains unsanitized user input, is retrieved from the OutputPage and returned as the tagline:\nhttps://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/0d8a44011e02a081618359a1e90f462478e807aa/includes/Components/CitizenComponentPageHeading.php#L249-L251\nThe tagline is then provided to the template data:\nhttps://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/0d8a44011e02a081618359a1e90f462478e807aa/includes/Components/CitizenComponentPageHeading.php#L270-L275\nThe template then inserts the tagline into raw HTML without doing any escaping:\nhttps://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/0d8a44011e02a081618359a1e90f462478e807aa/templates/PageHeading.mustache#L12\n\n### PoC\n1. Enable Citizen and ShortDescription\n2. Add `{{SHORTDESC:\u0026lt;img src=\"\" onerror=\"alert(\u0027citizen shortdescription xss\u0027)\"\u0026gt;}}` to a page\n3. Visit the page\n\n\n\n\n### Impact\nArbitrary HTML can be inserted into the DOM by any user, allowing for JavaScript to be executed.", "id": "GHSA-prmv-7r8c-794g", "modified": "2025-07-03T21:53:07Z", "published": "2025-07-03T21:29:16Z", "references": [ { "type": "WEB", "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen/security/advisories/GHSA-prmv-7r8c-794g" }, { "type": "ADVISORY", "url": "https://nvd.nist.gov/vuln/detail/CVE-2025-53370" }, { "type": "WEB", "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen/commit/aedbceb3380bb48db6b59e272fc187529c71c8ca" }, { "type": "WEB", "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen/commit/c85a40bddc8651fff66df83a72debddcb34f0521" }, { "type": "PACKAGE", "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen" }, { "type": "WEB", "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen/releases/tag/v3.4.0" } ], "schema_version": "1.4.0", "severity": [ { "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:L", "type": "CVSS_V3" } ], "summary": "Citizen vulnerable to Stored XSS through short descriptions" }
Sightings
Author | Source | Type | Date |
---|
Nomenclature
- Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
- Confirmed: The vulnerability is confirmed from an analyst perspective.
- Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
- Patched: This vulnerability was successfully patched by the user reporting the sighting.
- Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
- Not confirmed: The user expresses doubt about the veracity of the vulnerability.
- Not patched: This vulnerability was not successfully patched by the user reporting the sighting.