Vulnerability-Lookup

GHSA-XWH9-GC39-5298

Vulnerability from github – Published: 2023-11-28 17:36 – Updated: 2024-05-20 21:58

Summary

github.com/go-resty/resty/v2 HTTP request body disclosure

Details

A race condition in go-resty can result in HTTP request body disclosure across requests.

This condition can be triggered by calling sync.Pool.Put with the same *bytes.Buffer more than once, when request retries are enabled and a retry occurs. The call to sync.Pool.Get will then return a bytes.Buffer that hasn't had bytes.Buffer.Reset called on it. This dirty buffer will contain the HTTP request body from an unrelated request, and go-resty will append the current HTTP request body to it, sending two bodies in one request.

The sync.Pool in question is defined at package level scope, so a completely unrelated server could receive the request body.

Severity

5.9 (Medium)


                  
                    CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:N/A:N

Show details on source website

JSON

To clipboard

{
  "affected": [
    {
      "package": {
        "ecosystem": "Go",
        "name": "github.com/go-resty/resty/v2"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "2.10.0"
            },
            {
              "fixed": "2.11.0"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2023-45286"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-200",
      "CWE-362"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2023-11-28T17:36:21Z",
    "nvd_published_at": "2023-11-28T17:15:08Z",
    "severity": "MODERATE"
  },
  "details": "A race condition in go-resty can result in HTTP request body disclosure across requests.\n\nThis condition can be triggered by calling sync.Pool.Put with the same *bytes.Buffer more than once, when request retries are enabled and a retry occurs. The call to sync.Pool.Get will then return a bytes.Buffer that hasn\u0027t had bytes.Buffer.Reset called on it. This dirty buffer will contain the HTTP request body from an unrelated request, and go-resty will append the current HTTP request body to it, sending two bodies in one request.\n\nThe sync.Pool in question is defined at package level scope, so a completely unrelated server could receive the request body.",
  "id": "GHSA-xwh9-gc39-5298",
  "modified": "2024-05-20T21:58:12Z",
  "published": "2023-11-28T17:36:21Z",
  "references": [
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2023-45286"
    },
    {
      "type": "WEB",
      "url": "https://github.com/go-resty/resty/issues/739"
    },
    {
      "type": "WEB",
      "url": "https://github.com/go-resty/resty/issues/743"
    },
    {
      "type": "WEB",
      "url": "https://github.com/go-resty/resty/pull/745"
    },
    {
      "type": "WEB",
      "url": "https://github.com/go-resty/resty/commit/577fed8730d79f583eb48dfc81674164e1fc471e"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/go-resty/resty"
    },
    {
      "type": "WEB",
      "url": "https://github.com/go-resty/resty/releases/tag/v2.11.0"
    },
    {
      "type": "WEB",
      "url": "https://pkg.go.dev/vuln/GO-2023-2328"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:N/A:N",
      "type": "CVSS_V3"
    }
  ],
  "summary": "github.com/go-resty/resty/v2 HTTP request body disclosure"
}

CVE-2023-45286 (GCVE-0-2023-45286)

Vulnerability from cvelistv5 – Published: 2023-11-28 16:31 – Updated: 2024-08-28 20:01

Title

HTTP request body disclosure in github.com/go-resty/resty/v2

Summary

A race condition in go-resty can result in HTTP request body disclosure across requests. This condition can be triggered by calling sync.Pool.Put with the same *bytes.Buffer more than once, when request retries are enabled and a retry occurs. The call to sync.Pool.Get will then return a bytes.Buffer that hasn't had bytes.Buffer.Reset called on it. This dirty buffer will contain the HTTP request body from an unrelated request, and go-resty will append the current HTTP request body to it, sending two bodies in one request. The sync.Pool in question is defined at package level scope, so a completely unrelated server could receive the request body.

Severity

No CVSS data available.

SSVC

Exploitation: none Automatable: no Technical Impact: partial

CISA Coordinator · CISA-ADP (v2.0.3)

Decision recorded 2024-08-28 20:00 UTC

CWE

CWE-200 - Exposure of Sensitive Information to an Unauthorized Actor

Assigner

Go Google root

References

5 references

URL	Tags
https://github.com/go-resty/resty/issues/743
https://github.com/go-resty/resty/issues/739
https://github.com/go-resty/resty/pull/745
https://github.com/go-resty/resty/commit/577fed87…
https://pkg.go.dev/vuln/GO-2023-2328

Impacted products

1 product

Vendor	Product	Version
github.com/go-resty/resty/v2	github.com/go-resty/resty/v2	Affected: 2.10.0 , < 2.11.0 (semver)

Credits

Logan Attwood (@lattwood)

Show details on NVD website

JSON

To clipboard

{
  "containers": {
    "adp": [
      {
        "providerMetadata": {
          "dateUpdated": "2024-08-02T20:21:15.309Z",
          "orgId": "af854a3a-2127-422b-91ae-364da2661108",
          "shortName": "CVE"
        },
        "references": [
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://github.com/go-resty/resty/issues/743"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://github.com/go-resty/resty/issues/739"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://github.com/go-resty/resty/pull/745"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://github.com/go-resty/resty/commit/577fed8730d79f583eb48dfc81674164e1fc471e"
          },
          {
            "tags": [
              "x_transferred"
            ],
            "url": "https://pkg.go.dev/vuln/GO-2023-2328"
          }
        ],
        "title": "CVE Program Container"
      },
      {
        "metrics": [
          {
            "other": {
              "content": {
                "id": "CVE-2023-45286",
                "options": [
                  {
                    "Exploitation": "none"
                  },
                  {
                    "Automatable": "no"
                  },
                  {
                    "Technical Impact": "partial"
                  }
                ],
                "role": "CISA Coordinator",
                "timestamp": "2024-08-28T20:00:00.708483Z",
                "version": "2.0.3"
              },
              "type": "ssvc"
            }
          }
        ],
        "providerMetadata": {
          "dateUpdated": "2024-08-28T20:01:23.626Z",
          "orgId": "134c704f-9b21-4f2e-91b3-4a467353bcc0",
          "shortName": "CISA-ADP"
        },
        "title": "CISA ADP Vulnrichment"
      }
    ],
    "cna": {
      "affected": [
        {
          "collectionURL": "https://pkg.go.dev",
          "defaultStatus": "unaffected",
          "packageName": "github.com/go-resty/resty/v2",
          "product": "github.com/go-resty/resty/v2",
          "programRoutines": [
            {
              "name": "handleRequestBody"
            },
            {
              "name": "Backoff"
            },
            {
              "name": "Request.Delete"
            },
            {
              "name": "Request.Execute"
            },
            {
              "name": "Request.Get"
            },
            {
              "name": "Request.Head"
            },
            {
              "name": "Request.Options"
            },
            {
              "name": "Request.Patch"
            },
            {
              "name": "Request.Post"
            },
            {
              "name": "Request.Put"
            },
            {
              "name": "Request.Send"
            }
          ],
          "vendor": "github.com/go-resty/resty/v2",
          "versions": [
            {
              "lessThan": "2.11.0",
              "status": "affected",
              "version": "2.10.0",
              "versionType": "semver"
            }
          ]
        }
      ],
      "credits": [
        {
          "lang": "en",
          "value": "Logan Attwood (@lattwood)"
        }
      ],
      "descriptions": [
        {
          "lang": "en",
          "value": "A race condition in go-resty can result in HTTP request body disclosure across requests. This condition can be triggered by calling sync.Pool.Put with the same *bytes.Buffer more than once, when request retries are enabled and a retry occurs. The call to sync.Pool.Get will then return a bytes.Buffer that hasn\u0027t had bytes.Buffer.Reset called on it. This dirty buffer will contain the HTTP request body from an unrelated request, and go-resty will append the current HTTP request body to it, sending two bodies in one request. The sync.Pool in question is defined at package level scope, so a completely unrelated server could receive the request body."
        }
      ],
      "problemTypes": [
        {
          "descriptions": [
            {
              "description": "CWE-200: Exposure of Sensitive Information to an Unauthorized Actor",
              "lang": "en"
            }
          ]
        }
      ],
      "providerMetadata": {
        "dateUpdated": "2024-01-04T18:41:48.460Z",
        "orgId": "1bb62c36-49e3-4200-9d77-64a1400537cc",
        "shortName": "Go"
      },
      "references": [
        {
          "url": "https://github.com/go-resty/resty/issues/743"
        },
        {
          "url": "https://github.com/go-resty/resty/issues/739"
        },
        {
          "url": "https://github.com/go-resty/resty/pull/745"
        },
        {
          "url": "https://github.com/go-resty/resty/commit/577fed8730d79f583eb48dfc81674164e1fc471e"
        },
        {
          "url": "https://pkg.go.dev/vuln/GO-2023-2328"
        }
      ],
      "title": "HTTP request body disclosure in github.com/go-resty/resty/v2"
    }
  },
  "cveMetadata": {
    "assignerOrgId": "1bb62c36-49e3-4200-9d77-64a1400537cc",
    "assignerShortName": "Go",
    "cveId": "CVE-2023-45286",
    "datePublished": "2023-11-28T16:31:21.078Z",
    "dateReserved": "2023-10-06T17:06:26.221Z",
    "dateUpdated": "2024-08-28T20:01:23.626Z",
    "state": "PUBLISHED"
  },
  "dataType": "CVE_RECORD",
  "dataVersion": "5.1"
}

Sightings

Author	Source	Type	Date	Other

Nomenclature

Seen: The vulnerability was mentioned, discussed, or observed by the user.
Confirmed: The vulnerability has been validated from an analyst's perspective.
Published Proof of Concept: A public proof of concept is available for this vulnerability.
Exploited: The vulnerability was observed as exploited by the user who reported the sighting.
Patched: The vulnerability was observed as successfully patched by the user who reported the sighting.
Not exploited: The vulnerability was not observed as exploited by the user who reported the sighting.
Not confirmed: The user expressed doubt about the validity of the vulnerability.
Not patched: The vulnerability was not observed as successfully patched by the user who reported the sighting.

Detection rules are retrieved from Rulezet.

The MITRE ATT&CK techniques below are AI-generated suggestions, inferred from the description of the vulnerability by the CIRCL/vulnerability-attack-technique-classification-roberta-base model, served locally by ML-Gateway. They have not been verified by an analyst and are provided for guidance only.
The approach is described in our paper Mapping CVEs to MITRE ATT&CK Techniques: A Curated Gold-Set Classifier and the Limits of LLM-Assisted Label Expansion.
Browse all ATT&CK techniques and the vulnerabilities related to each.

Related by attack behaviour

Vulnerabilities whose description is nearest to this one in the vector space of the CIRCL/vulnerability-attack-technique-biencoder model. This is a similarity search over the bi-encoder space (plain cosine), not a classification, and it has no measured accuracy.