ghsa-rq6g-6g94-jfr4
Vulnerability from github
Published
2025-07-03 20:29
Modified
2025-07-03 21:51
Summary
starcitizentools/citizen-skin is vulnerable to Stored XSS attack in the legacy search bar through page descriptions
Details

Summary

Page descriptions are inserted into raw HTML without proper sanitization by the Citizen skin when using the old search bar.

Details

The descriptions, which are unsanitized, are inserted as raw HTML: https://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/d4dfc3697a82948b3b9c4d44e9a273c79bc86b87/resources/skins.citizen.search/templates/TypeaheadListItem.mustache#L18

PoC

All of the reproduction methods require the command palette to be disabled via $wgCitizenEnableCommandPalette = false;. Additionally, the action API must be used as the Search Gateway via $wgCitizenSearchGateway = 'mwActionApi';.

TextExtracts as the description source

  • Enable the TextExtracts extension
  • Add $wgCitizenSearchDescriptionSource = 'textextracts'; to your LocalSettings.php
  • Create a page called CitizenXSSTextExtracts and insert <img src="" onerror="alert('citizen search xss')"> into it
  • Open the search modal and search for CitizenXSSTextExtracts

image

Description2 as the description source

  • Enable the Description2 extension
  • Add $wgEnableMetaDescriptionFunctions = true; to your LocalSettings.php to enable the {{#description2:}} parser function
  • Add $wgCitizenSearchDescriptionSource = 'pagedescription'; to your LocalSettings.php
  • Create a page called CitizenXSSDescription2 and insert {{#description2:<img src="" onerror="alert('citizen search xss 2')">}} into it
  • Open the search modal and search for CitizenXSSDescription2

image

Wikibase as the description source

Note that this method is currently untested due to issues I experienced when setting up Wikibase.

  • Enable Wikibase client + repo in your wiki
  • Add $wgCitizenSearchDescriptionSource = 'wikidata'; to your LocalSettings.php
  • Have an item with a description like <img src="" onerror="alert('citizen search xss 3')">
  • Open the search modal and search for the page linked to the item

ShortDescription as the description source

  • Enable the ShortDescription extension
  • Add $wgCitizenSearchDescriptionSource = 'wikidata'; to your LocalSettings.php
  • Create a page called CitizenXSSDescription4 and insert {{SHORTDESC:<img src="" onerror="alert('citizen search xss 4')">}} into it
  • Open the search modal and search for CitizenXSSDescription4

Impact

On all wikis that use the aforementioned settings (command palette disabled or using an old release where the old search bar is still used; using the action API as the search gateway), anybody who can edit pages is able to insert XSS payloads into the DOM for other users who are searching for specific pages.

Show details on source website


{
  "affected": [
    {
      "package": {
        "ecosystem": "Packagist",
        "name": "starcitizentools/citizen-skin"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "1.9.4"
            },
            {
              "fixed": "3.4.0"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2025-53368"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-79"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2025-07-03T20:29:08Z",
    "nvd_published_at": "2025-07-03T20:15:23Z",
    "severity": "HIGH"
  },
  "details": "### Summary\nPage descriptions are inserted into raw HTML without proper sanitization by the Citizen skin when using the old search bar.\n\n### Details\n\nThe descriptions, which are unsanitized, are inserted as raw HTML:\nhttps://github.com/StarCitizenTools/mediawiki-skins-Citizen/blob/d4dfc3697a82948b3b9c4d44e9a273c79bc86b87/resources/skins.citizen.search/templates/TypeaheadListItem.mustache#L18\n\n### PoC\n\n\nAll of the reproduction methods require the command palette to be disabled via `$wgCitizenEnableCommandPalette = false;`.\nAdditionally, the action API must be used as the Search Gateway via  `$wgCitizenSearchGateway = \u0027mwActionApi\u0027;`.\n\n\n#### TextExtracts as the description source\n\n* Enable the TextExtracts extension\n* Add `$wgCitizenSearchDescriptionSource = \u0027textextracts\u0027;` to your LocalSettings.php\n* Create a page called `CitizenXSSTextExtracts` and insert `\u003cimg src=\"\" onerror=\"alert(\u0027citizen search xss\u0027)\"\u003e` into it\n* Open the search modal and search for `CitizenXSSTextExtracts`\n\n![image](https://github.com/user-attachments/assets/fbc88458-c429-4f08-9376-584b7db93f58)\n\n\n#### Description2 as the description source\n\n* Enable the Description2 extension\n* Add `$wgEnableMetaDescriptionFunctions = true;` to your LocalSettings.php to enable the `{{#description2:}}` parser function\n* Add `$wgCitizenSearchDescriptionSource = \u0027pagedescription\u0027;` to your LocalSettings.php\n* Create a page called `CitizenXSSDescription2` and insert `{{#description2:\u003cimg src=\"\" onerror=\"alert(\u0027citizen search xss 2\u0027)\"\u003e}}` into it\n* Open the search modal and search for `CitizenXSSDescription2`\n\n![image](https://github.com/user-attachments/assets/24513eba-dbec-4bc6-ac06-6276d509fcab)\n\n\n#### Wikibase as the description source\n\nNote that this method is currently untested due to issues I experienced when setting up Wikibase.\n\n* Enable Wikibase client + repo in your wiki\n* Add `$wgCitizenSearchDescriptionSource = \u0027wikidata\u0027;` to your LocalSettings.php\n* Have an item with a description like `\u003cimg src=\"\" onerror=\"alert(\u0027citizen search xss 3\u0027)\"\u003e`\n* Open the search modal and search for the page linked to the item\n\n\n#### ShortDescription as the description source\n\n* Enable the ShortDescription extension\n* Add `$wgCitizenSearchDescriptionSource = \u0027wikidata\u0027;` to your LocalSettings.php\n* Create a page called `CitizenXSSDescription4` and insert `{{SHORTDESC:\u003cimg src=\"\" onerror=\"alert(\u0027citizen search xss 4\u0027)\"\u003e}}` into it\n* Open the search modal and search for `CitizenXSSDescription4`\n\n### Impact\n\nOn all wikis that use the aforementioned settings (command palette disabled or using an old release where the old search bar is still used; using the action API as the search gateway), anybody who can edit pages is able to insert XSS payloads into the DOM for other users who are searching for specific pages.",
  "id": "GHSA-rq6g-6g94-jfr4",
  "modified": "2025-07-03T21:51:57Z",
  "published": "2025-07-03T20:29:08Z",
  "references": [
    {
      "type": "WEB",
      "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen/security/advisories/GHSA-rq6g-6g94-jfr4"
    },
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2025-53368"
    },
    {
      "type": "WEB",
      "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen/commit/aedbceb3380bb48db6b59e272fc187529c71c8ca"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen"
    },
    {
      "type": "WEB",
      "url": "https://github.com/StarCitizenTools/mediawiki-skins-Citizen/releases/tag/v3.4.0"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:L/A:L",
      "type": "CVSS_V3"
    }
  ],
  "summary": "starcitizentools/citizen-skin is vulnerable to Stored XSS attack in the legacy search bar through page descriptions"
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.


Loading…

Loading…

Loading…

Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
  • Confirmed: The vulnerability is confirmed from an analyst perspective.
  • Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
  • Patched: This vulnerability was successfully patched by the user reporting the sighting.
  • Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
  • Not confirmed: The user expresses doubt about the veracity of the vulnerability.
  • Not patched: This vulnerability was not successfully patched by the user reporting the sighting.


Loading…