ghsa-qjqp-xr96-cj99
Vulnerability from github
The Trix editor, versions prior to 2.1.1, is vulnerable to arbitrary code execution when copying and pasting content from the web or other documents with markup into the editor. The vulnerability stems from improper sanitization of pasted content, allowing an attacker to embed malicious scripts which are executed within the context of the application.
Vulnerable Versions:
- 1.x series up to and including 1.3.1
- 2.x series up to and including 2.1.0
Fixed Versions:
- v1.3.2
- v2.1.1
Vector:
- Bug 1: When copying content manipulated by a script, such as:
js
document.addEventListener('copy', function(e){
e.clipboardData.setData('text/html', '<div><noscript><div class="123</noscript>456<img src=1 onerror=alert(1)//"></div></noscript></div>');
e.preventDefault();
});
and pasting into the Trix editor, the script within the content is executed.
- Bug 2: Similar execution occurs with content structured as:
js
document.write(`copy<div data-trix-attachment="{"contentType":"text/html","content":"<img src=1 onerror=alert(101)>HELLO123"}"></div>me`);
Impact:
An attacker could exploit these vulnerabilities to execute arbitrary JavaScript code within the context of the user's session, potentially leading to unauthorized actions being performed or sensitive information being disclosed.
Remediation:
Update Recommendation: Users should upgrade to Trix editor version 2.1.1 or later, which incorporates proper sanitization of input from copied content.
CSP Enhancement: Additionally, enhancing the Content Security Policy (CSP) to disallow inline scripts can significantly mitigate the risk of such vulnerabilities. Set CSP policies such as script-src 'self' to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using script-src-elem.
References:
- https://github.com/basecamp/trix/releases/tag/v2.1.1
- https://github.com/basecamp/trix/pull/1147
- https://github.com/basecamp/trix/pull/1149
- https://github.com/basecamp/trix/pull/1153
Credit: These issues were reported by security researchers loknop and pinpie.
{
"affected": [
{
"package": {
"ecosystem": "npm",
"name": "trix"
},
"ranges": [
{
"events": [
{
"introduced": "2.0.0"
},
{
"fixed": "2.1.1"
}
],
"type": "ECOSYSTEM"
}
]
},
{
"package": {
"ecosystem": "npm",
"name": "trix"
},
"ranges": [
{
"events": [
{
"introduced": "0.9.0"
},
{
"fixed": "1.3.2"
}
],
"type": "ECOSYSTEM"
}
]
},
{
"package": {
"ecosystem": "RubyGems",
"name": "actiontext"
},
"ranges": [
{
"events": [
{
"introduced": "7.0.0.alpha1"
},
{
"fixed": "7.0.8.3"
}
],
"type": "ECOSYSTEM"
}
]
},
{
"package": {
"ecosystem": "RubyGems",
"name": "actiontext"
},
"ranges": [
{
"events": [
{
"introduced": "7.1.0.beta1"
},
{
"fixed": "7.1.3.3"
}
],
"type": "ECOSYSTEM"
}
]
}
],
"aliases": [
"CVE-2024-34341"
],
"database_specific": {
"cwe_ids": [
"CWE-79"
],
"github_reviewed": true,
"github_reviewed_at": "2024-05-07T16:49:24Z",
"nvd_published_at": "2024-05-07T16:15:08Z",
"severity": "MODERATE"
},
"details": "The Trix editor, versions prior to 2.1.1, is vulnerable to arbitrary code execution when copying and pasting content from the web or other documents with markup into the editor. The vulnerability stems from improper sanitization of pasted content, allowing an attacker to embed malicious scripts which are executed within the context of the application.\n\n**Vulnerable Versions**: \n\n- 1.x series up to and including 1.3.1\n- 2.x series up to and including 2.1.0\n\n**Fixed Versions**: \n\n- v1.3.2\n- v2.1.1\n\n**Vector**:\n\n- **Bug 1**: When copying content manipulated by a script, such as:\n\n```js\ndocument.addEventListener(\u0027copy\u0027, function(e){\n e.clipboardData.setData(\u0027text/html\u0027, \u0027\u003cdiv\u003e\u003cnoscript\u003e\u003cdiv class=\"123\u003c/noscript\u003e456\u003cimg src=1 onerror=alert(1)//\"\u003e\u003c/div\u003e\u003c/noscript\u003e\u003c/div\u003e\u0027);\n e.preventDefault();\n});\n```\n\nand pasting into the Trix editor, the script within the content is executed.\n\n- **Bug 2**: Similar execution occurs with content structured as:\n\n```js\ndocument.write(`copy\u003cdiv data-trix-attachment=\"{\u0026quot;contentType\u0026quot;:\u0026quot;text/html\u0026quot;,\u0026quot;content\u0026quot;:\u0026quot;\u0026lt;img src=1 onerror=alert(101)\u0026gt;HELLO123\u0026quot;}\"\u003e\u003c/div\u003eme`);\n```\n\n### Impact:\nAn attacker could exploit these vulnerabilities to execute arbitrary JavaScript code within the context of the user\u0027s session, potentially leading to unauthorized actions being performed or sensitive information being disclosed.\n\n### Remediation:\n\n**Update Recommendation**: Users should upgrade to Trix editor version 2.1.1 or later, which incorporates proper sanitization of input from copied content.\n\n**CSP Enhancement**: Additionally, enhancing the Content Security Policy (CSP) to disallow inline scripts can significantly mitigate the risk of such vulnerabilities. Set CSP policies such as script-src \u0027self\u0027 to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using script-src-elem.\n\n### References:\n - https://github.com/basecamp/trix/releases/tag/v2.1.1\n - https://github.com/basecamp/trix/pull/1147\n - https://github.com/basecamp/trix/pull/1149\n - https://github.com/basecamp/trix/pull/1153\n\n**Credit**: These issues were reported by security researchers [loknop](https://hackerone.com/loknop) and [pinpie](https://hackerone.com/pinpie).",
"id": "GHSA-qjqp-xr96-cj99",
"modified": "2024-06-03T17:24:56Z",
"published": "2024-05-07T16:49:24Z",
"references": [
{
"type": "WEB",
"url": "https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99"
},
{
"type": "ADVISORY",
"url": "https://nvd.nist.gov/vuln/detail/CVE-2024-34341"
},
{
"type": "WEB",
"url": "https://github.com/basecamp/trix/pull/1147"
},
{
"type": "WEB",
"url": "https://github.com/basecamp/trix/pull/1149"
},
{
"type": "WEB",
"url": "https://github.com/basecamp/trix/commit/1a5c68a14d48421fc368e30026f4a7918028b7ad"
},
{
"type": "WEB",
"url": "https://github.com/basecamp/trix/commit/841ff19b53f349915100bca8fcb488214ff93554"
},
{
"type": "WEB",
"url": "https://github.com/rails/rails/commit/07e6c88cc4defe6f6b8d28e79eb13a518e15b14c"
},
{
"type": "WEB",
"url": "https://github.com/rails/rails/commit/260cb392fc1ee91d0b749cff08d1c8d54b230bd3"
},
{
"type": "WEB",
"url": "https://github.com/rails/rails/commit/73fac32511eefdd45d8f00fecc2b8cc5408ea6d5"
},
{
"type": "WEB",
"url": "https://discuss.rubyonrails.org/t/xss-vulnerabilities-in-trix-editor/85803"
},
{
"type": "PACKAGE",
"url": "https://github.com/basecamp/trix"
},
{
"type": "WEB",
"url": "https://github.com/basecamp/trix/releases/tag/v2.1.1"
},
{
"type": "WEB",
"url": "https://github.com/rubysec/ruby-advisory-db/blob/master/gems/actiontext/CVE-2024-34341.yml"
},
{
"type": "WEB",
"url": "https://rubyonrails.org/2024/5/17/Rails-Versions-7-0-8-2-and-7-1-3-3-have-been-released"
},
{
"type": "WEB",
"url": "https://rubyonrails.org/2024/5/17/Rails-Versions-7-0-8-3-has-been-released"
}
],
"schema_version": "1.4.0",
"severity": [
{
"score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:L/I:L/A:N",
"type": "CVSS_V3"
}
],
"summary": "Trix Editor Arbitrary Code Execution Vulnerability"
}
Sightings
| Author | Source | Type | Date |
|---|
Nomenclature
- Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
- Confirmed: The vulnerability is confirmed from an analyst perspective.
- Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
- Patched: This vulnerability was successfully patched by the user reporting the sighting.
- Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
- Not confirmed: The user expresses doubt about the veracity of the vulnerability.
- Not patched: This vulnerability was not successfully patched by the user reporting the sighting.