CVE-2024-42256 (GCVE-0-2024-42256)
Vulnerability from cvelistv5
Published
2024-08-08 08:49
Modified
2025-05-04 09:25
Severity ?
Summary
In the Linux kernel, the following vulnerability has been resolved: cifs: Fix server re-repick on subrequest retry When a subrequest is marked for needing retry, netfs will call cifs_prepare_write() which will make cifs repick the server for the op before renegotiating credits; it then calls cifs_issue_write() which invokes smb2_async_writev() - which re-repicks the server. If a different server is then selected, this causes the increment of server->in_flight to happen against one record and the decrement to happen against another, leading to misaccounting. Fix this by just removing the repick code in smb2_async_writev(). As this is only called from netfslib-driven code, cifs_prepare_write() should always have been called first, and so server should never be NULL and the preparatory step is repeated in the event that we do a retry. The problem manifests as a warning looking something like: WARNING: CPU: 4 PID: 72896 at fs/smb/client/smb2ops.c:97 smb2_add_credits+0x3f0/0x9e0 [cifs] ... RIP: 0010:smb2_add_credits+0x3f0/0x9e0 [cifs] ... smb2_writev_callback+0x334/0x560 [cifs] cifs_demultiplex_thread+0x77a/0x11b0 [cifs] kthread+0x187/0x1d0 ret_from_fork+0x34/0x60 ret_from_fork_asm+0x1a/0x30 Which may be triggered by a number of different xfstests running against an Azure server in multichannel mode. generic/249 seems the most repeatable, but generic/215, generic/249 and generic/308 may also show it.
References
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/b1d0a566769b6fb3795b5289fc1daf9e0638d97aPatch
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/de40579b903883274fe203865f29d66b168b7236Patch
Impacted products
Vendor Product Version
Linux Linux Version: 3ee1a1fc39819906f04d6c62c180e760cd3a689d
Version: 3ee1a1fc39819906f04d6c62c180e760cd3a689d
 Create a notification for this product.
   Linux Linux Version: 6.10
 Create a notification for this product.
Show details on NVD website

To clipboard 

{
  "containers": {
    "adp": [
      {
        "metrics": [
          {
            "other": {
              "content": {
                "id": "CVE-2024-42256",
                "options": [
                  {
                    "Exploitation": "none"
                  },
                  {
                    "Automatable": "no"
                  },
                  {
                    "Technical Impact": "partial"
                  }
                ],
                "role": "CISA Coordinator",
                "timestamp": "2024-09-10T16:12:59.830016Z",
                "version": "2.0.3"
              },
              "type": "ssvc"
            }
          }
        ],
        "providerMetadata": {
          "dateUpdated": "2024-09-11T17:34:30.018Z",
          "orgId": "134c704f-9b21-4f2e-91b3-4a467353bcc0",
          "shortName": "CISA-ADP"
        },
        "title": "CISA ADP Vulnrichment"
      }
    ],
    "cna": {
      "affected": [
        {
          "defaultStatus": "unaffected",
          "product": "Linux",
          "programFiles": [
            "fs/smb/client/smb2pdu.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "lessThan": "b1d0a566769b6fb3795b5289fc1daf9e0638d97a",
              "status": "affected",
              "version": "3ee1a1fc39819906f04d6c62c180e760cd3a689d",
              "versionType": "git"
            },
            {
              "lessThan": "de40579b903883274fe203865f29d66b168b7236",
              "status": "affected",
              "version": "3ee1a1fc39819906f04d6c62c180e760cd3a689d",
              "versionType": "git"
            }
          ]
        },
        {
          "defaultStatus": "affected",
          "product": "Linux",
          "programFiles": [
            "fs/smb/client/smb2pdu.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "status": "affected",
              "version": "6.10"
            },
            {
              "lessThan": "6.10",
              "status": "unaffected",
              "version": "0",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "6.10.*",
              "status": "unaffected",
              "version": "6.10.1",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "*",
              "status": "unaffected",
              "version": "6.11",
              "versionType": "original_commit_for_fix"
            }
          ]
        }
      ],
      "cpeApplicability": [
        {
          "nodes": [
            {
              "cpeMatch": [
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.10.1",
                  "versionStartIncluding": "6.10",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.11",
                  "versionStartIncluding": "6.10",
                  "vulnerable": true
                }
              ],
              "negate": false,
              "operator": "OR"
            }
          ]
        }
      ],
      "descriptions": [
        {
          "lang": "en",
          "value": "In the Linux kernel, the following vulnerability has been resolved:\n\ncifs: Fix server re-repick on subrequest retry\n\nWhen a subrequest is marked for needing retry, netfs will call\ncifs_prepare_write() which will make cifs repick the server for the op\nbefore renegotiating credits; it then calls cifs_issue_write() which\ninvokes smb2_async_writev() - which re-repicks the server.\n\nIf a different server is then selected, this causes the increment of\nserver-\u003ein_flight to happen against one record and the decrement to happen\nagainst another, leading to misaccounting.\n\nFix this by just removing the repick code in smb2_async_writev().  As this\nis only called from netfslib-driven code, cifs_prepare_write() should\nalways have been called first, and so server should never be NULL and the\npreparatory step is repeated in the event that we do a retry.\n\nThe problem manifests as a warning looking something like:\n\n WARNING: CPU: 4 PID: 72896 at fs/smb/client/smb2ops.c:97 smb2_add_credits+0x3f0/0x9e0 [cifs]\n ...\n RIP: 0010:smb2_add_credits+0x3f0/0x9e0 [cifs]\n ...\n  smb2_writev_callback+0x334/0x560 [cifs]\n  cifs_demultiplex_thread+0x77a/0x11b0 [cifs]\n  kthread+0x187/0x1d0\n  ret_from_fork+0x34/0x60\n  ret_from_fork_asm+0x1a/0x30\n\nWhich may be triggered by a number of different xfstests running against an\nAzure server in multichannel mode.  generic/249 seems the most repeatable,\nbut generic/215, generic/249 and generic/308 may also show it."
        }
      ],
      "providerMetadata": {
        "dateUpdated": "2025-05-04T09:25:18.631Z",
        "orgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
        "shortName": "Linux"
      },
      "references": [
        {
          "url": "https://git.kernel.org/stable/c/b1d0a566769b6fb3795b5289fc1daf9e0638d97a"
        },
        {
          "url": "https://git.kernel.org/stable/c/de40579b903883274fe203865f29d66b168b7236"
        }
      ],
      "title": "cifs: Fix server re-repick on subrequest retry",
      "x_generator": {
        "engine": "bippy-1.2.0"
      }
    }
  },
  "cveMetadata": {
    "assignerOrgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
    "assignerShortName": "Linux",
    "cveId": "CVE-2024-42256",
    "datePublished": "2024-08-08T08:49:15.813Z",
    "dateReserved": "2024-07-30T07:40:12.257Z",
    "dateUpdated": "2025-05-04T09:25:18.631Z",
    "state": "PUBLISHED"
  },
  "dataType": "CVE_RECORD",
  "dataVersion": "5.1",
  "vulnerability-lookup:meta": {
    "nvd": "{\"cve\":{\"id\":\"CVE-2024-42256\",\"sourceIdentifier\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\",\"published\":\"2024-08-08T09:15:08.553\",\"lastModified\":\"2024-09-06T13:56:00.207\",\"vulnStatus\":\"Analyzed\",\"cveTags\":[],\"descriptions\":[{\"lang\":\"en\",\"value\":\"In the Linux kernel, the following vulnerability has been resolved:\\n\\ncifs: Fix server re-repick on subrequest retry\\n\\nWhen a subrequest is marked for needing retry, netfs will call\\ncifs_prepare_write() which will make cifs repick the server for the op\\nbefore renegotiating credits; it then calls cifs_issue_write() which\\ninvokes smb2_async_writev() - which re-repicks the server.\\n\\nIf a different server is then selected, this causes the increment of\\nserver-\u003ein_flight to happen against one record and the decrement to happen\\nagainst another, leading to misaccounting.\\n\\nFix this by just removing the repick code in smb2_async_writev().  As this\\nis only called from netfslib-driven code, cifs_prepare_write() should\\nalways have been called first, and so server should never be NULL and the\\npreparatory step is repeated in the event that we do a retry.\\n\\nThe problem manifests as a warning looking something like:\\n\\n WARNING: CPU: 4 PID: 72896 at fs/smb/client/smb2ops.c:97 smb2_add_credits+0x3f0/0x9e0 [cifs]\\n ...\\n RIP: 0010:smb2_add_credits+0x3f0/0x9e0 [cifs]\\n ...\\n  smb2_writev_callback+0x334/0x560 [cifs]\\n  cifs_demultiplex_thread+0x77a/0x11b0 [cifs]\\n  kthread+0x187/0x1d0\\n  ret_from_fork+0x34/0x60\\n  ret_from_fork_asm+0x1a/0x30\\n\\nWhich may be triggered by a number of different xfstests running against an\\nAzure server in multichannel mode.  generic/249 seems the most repeatable,\\nbut generic/215, generic/249 and generic/308 may also show it.\"},{\"lang\":\"es\",\"value\":\"En el kernel de Linux, se ha resuelto la siguiente vulnerabilidad: cifs: corrige la repetici\u00f3n del servidor en el reintento de subrequest Cuando se marca una subrequest para necesitar un reintento, netfs llamar\u00e1 a cifs_prepare_write(), lo que har\u00e1 que cifs vuelva a seleccionar el servidor para la operaci\u00f3n antes de renegociar los cr\u00e9ditos; luego llama a cifs_issue_write(), que invoca a smb2_async_writev(), que vuelve a seleccionar el servidor. Si luego se selecciona un servidor diferente, esto hace que el incremento de server-\u0026gt;in_flight ocurra en un registro y la disminuci\u00f3n en otro, lo que lleva a una contabilidad err\u00f3nea. Solucione este problema simplemente eliminando el c\u00f3digo de repetici\u00f3n en smb2_async_writev(). Como esto solo se llama desde c\u00f3digo controlado por netfslib, siempre se deber\u00eda haber llamado primero a cifs_prepare_write(), por lo que el servidor nunca deber\u00eda ser NULL y el paso preparatorio se repite en caso de que hagamos un reintento. El problema se manifiesta como una advertencia similar a: ADVERTENCIA: CPU: 4 PID: 72896 en fs/smb/client/smb2ops.c:97 smb2_add_credits+0x3f0/0x9e0 [cifs] ... RIP: 0010:smb2_add_credits+0x3f0/0x9e0 [cifs] ... smb2_writev_callback+0x334/0x560 [cifs] cifs_demultiplex_thread+0x77a/0x11b0 [cifs] kthread+0x187/0x1d0 ret_from_fork+0x34/0x60 ret_from_fork_asm+0x1a/0x30 Que puede ser activado por varios xfstests corriendo contra un Servidor Azure en modo multicanal. generic/249 parece el m\u00e1s repetible, pero generic/215, generic/249 y generic/308 tambi\u00e9n pueden mostrarlo.\"}],\"metrics\":{\"cvssMetricV31\":[{\"source\":\"nvd@nist.gov\",\"type\":\"Primary\",\"cvssData\":{\"version\":\"3.1\",\"vectorString\":\"CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H\",\"baseScore\":9.8,\"baseSeverity\":\"CRITICAL\",\"attackVector\":\"NETWORK\",\"attackComplexity\":\"LOW\",\"privilegesRequired\":\"NONE\",\"userInteraction\":\"NONE\",\"scope\":\"UNCHANGED\",\"confidentialityImpact\":\"HIGH\",\"integrityImpact\":\"HIGH\",\"availabilityImpact\":\"HIGH\"},\"exploitabilityScore\":3.9,\"impactScore\":5.9}]},\"weaknesses\":[{\"source\":\"nvd@nist.gov\",\"type\":\"Primary\",\"description\":[{\"lang\":\"en\",\"value\":\"NVD-CWE-noinfo\"}]}],\"configurations\":[{\"nodes\":[{\"operator\":\"OR\",\"negate\":false,\"cpeMatch\":[{\"vulnerable\":true,\"criteria\":\"cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*\",\"versionStartIncluding\":\"6.10\",\"versionEndExcluding\":\"6.10.1\",\"matchCriteriaId\":\"CC5B6890-A2E7-41F8-AA56-E3202E9FB075\"}]}]}],\"references\":[{\"url\":\"https://git.kernel.org/stable/c/b1d0a566769b6fb3795b5289fc1daf9e0638d97a\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\",\"tags\":[\"Patch\"]},{\"url\":\"https://git.kernel.org/stable/c/de40579b903883274fe203865f29d66b168b7236\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\",\"tags\":[\"Patch\"]}]}}",
    "vulnrichment": {
      "containers": "{\"adp\": [{\"title\": \"CISA ADP Vulnrichment\", \"metrics\": [{\"other\": {\"type\": \"ssvc\", \"content\": {\"id\": \"CVE-2024-42256\", \"role\": \"CISA Coordinator\", \"options\": [{\"Exploitation\": \"none\"}, {\"Automatable\": \"no\"}, {\"Technical Impact\": \"partial\"}], \"version\": \"2.0.3\", \"timestamp\": \"2024-09-10T16:12:59.830016Z\"}}}], \"providerMetadata\": {\"orgId\": \"134c704f-9b21-4f2e-91b3-4a467353bcc0\", \"shortName\": \"CISA-ADP\", \"dateUpdated\": \"2024-09-11T12:42:24.038Z\"}}], \"cna\": {\"title\": \"cifs: Fix server re-repick on subrequest retry\", \"affected\": [{\"repo\": \"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git\", \"vendor\": \"Linux\", \"product\": \"Linux\", \"versions\": [{\"status\": \"affected\", \"version\": \"3ee1a1fc39819906f04d6c62c180e760cd3a689d\", \"lessThan\": \"b1d0a566769b6fb3795b5289fc1daf9e0638d97a\", \"versionType\": \"git\"}, {\"status\": \"affected\", \"version\": \"3ee1a1fc39819906f04d6c62c180e760cd3a689d\", \"lessThan\": \"de40579b903883274fe203865f29d66b168b7236\", \"versionType\": \"git\"}], \"programFiles\": [\"fs/smb/client/smb2pdu.c\"], \"defaultStatus\": \"unaffected\"}, {\"repo\": \"https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git\", \"vendor\": \"Linux\", \"product\": \"Linux\", \"versions\": [{\"status\": \"affected\", \"version\": \"6.10\"}, {\"status\": \"unaffected\", \"version\": \"0\", \"lessThan\": \"6.10\", \"versionType\": \"semver\"}, {\"status\": \"unaffected\", \"version\": \"6.10.1\", \"versionType\": \"semver\", \"lessThanOrEqual\": \"6.10.*\"}, {\"status\": \"unaffected\", \"version\": \"6.11\", \"versionType\": \"original_commit_for_fix\", \"lessThanOrEqual\": \"*\"}], \"programFiles\": [\"fs/smb/client/smb2pdu.c\"], \"defaultStatus\": \"affected\"}], \"references\": [{\"url\": \"https://git.kernel.org/stable/c/b1d0a566769b6fb3795b5289fc1daf9e0638d97a\"}, {\"url\": \"https://git.kernel.org/stable/c/de40579b903883274fe203865f29d66b168b7236\"}], \"x_generator\": {\"engine\": \"bippy-1.2.0\"}, \"descriptions\": [{\"lang\": \"en\", \"value\": \"In the Linux kernel, the following vulnerability has been resolved:\\n\\ncifs: Fix server re-repick on subrequest retry\\n\\nWhen a subrequest is marked for needing retry, netfs will call\\ncifs_prepare_write() which will make cifs repick the server for the op\\nbefore renegotiating credits; it then calls cifs_issue_write() which\\ninvokes smb2_async_writev() - which re-repicks the server.\\n\\nIf a different server is then selected, this causes the increment of\\nserver-\u003ein_flight to happen against one record and the decrement to happen\\nagainst another, leading to misaccounting.\\n\\nFix this by just removing the repick code in smb2_async_writev().  As this\\nis only called from netfslib-driven code, cifs_prepare_write() should\\nalways have been called first, and so server should never be NULL and the\\npreparatory step is repeated in the event that we do a retry.\\n\\nThe problem manifests as a warning looking something like:\\n\\n WARNING: CPU: 4 PID: 72896 at fs/smb/client/smb2ops.c:97 smb2_add_credits+0x3f0/0x9e0 [cifs]\\n ...\\n RIP: 0010:smb2_add_credits+0x3f0/0x9e0 [cifs]\\n ...\\n  smb2_writev_callback+0x334/0x560 [cifs]\\n  cifs_demultiplex_thread+0x77a/0x11b0 [cifs]\\n  kthread+0x187/0x1d0\\n  ret_from_fork+0x34/0x60\\n  ret_from_fork_asm+0x1a/0x30\\n\\nWhich may be triggered by a number of different xfstests running against an\\nAzure server in multichannel mode.  generic/249 seems the most repeatable,\\nbut generic/215, generic/249 and generic/308 may also show it.\"}], \"cpeApplicability\": [{\"nodes\": [{\"negate\": false, \"cpeMatch\": [{\"criteria\": \"cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*\", \"vulnerable\": true, \"versionEndExcluding\": \"6.10.1\", \"versionStartIncluding\": \"6.10\"}, {\"criteria\": \"cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*\", \"vulnerable\": true, \"versionEndExcluding\": \"6.11\", \"versionStartIncluding\": \"6.10\"}], \"operator\": \"OR\"}]}], \"providerMetadata\": {\"orgId\": \"416baaa9-dc9f-4396-8d5f-8c081fb06d67\", \"shortName\": \"Linux\", \"dateUpdated\": \"2025-05-04T09:25:18.631Z\"}}}",
      "cveMetadata": "{\"cveId\": \"CVE-2024-42256\", \"state\": \"PUBLISHED\", \"dateUpdated\": \"2025-05-04T09:25:18.631Z\", \"dateReserved\": \"2024-07-30T07:40:12.257Z\", \"assignerOrgId\": \"416baaa9-dc9f-4396-8d5f-8c081fb06d67\", \"datePublished\": \"2024-08-08T08:49:15.813Z\", \"assignerShortName\": \"Linux\"}",
      "dataType": "CVE_RECORD",
      "dataVersion": "5.1"
    }
  }
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
  • Confirmed: The vulnerability is confirmed from an analyst perspective.
  • Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
  • Patched: This vulnerability was successfully patched by the user reporting the sighting.
  • Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
  • Not confirmed: The user expresses doubt about the veracity of the vulnerability.
  • Not patched: This vulnerability was not successfully patched by the user reporting the sighting.