CVE-2021-4454 (GCVE-0-2021-4454)
Vulnerability from cvelistv5
Published
2025-03-27 16:37
Modified
2025-05-04 12:40
Severity ?
Summary
In the Linux kernel, the following vulnerability has been resolved: can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate The conclusion "j1939_session_deactivate() should be called with a session ref-count of at least 2" is incorrect. In some concurrent scenarios, j1939_session_deactivate can be called with the session ref-count less than 2. But there is not any problem because it will check the session active state before session putting in j1939_session_deactivate_locked(). Here is the concurrent scenario of the problem reported by syzbot and my reproduction log. cpu0 cpu1 j1939_xtp_rx_eoma j1939_xtp_rx_abort_one j1939_session_get_by_addr [kref == 2] j1939_session_get_by_addr [kref == 3] j1939_session_deactivate [kref == 2] j1939_session_put [kref == 1] j1939_session_completed j1939_session_deactivate WARN_ON_ONCE(kref < 2) ===================================================== WARNING: CPU: 1 PID: 21 at net/can/j1939/transport.c:1088 j1939_session_deactivate+0x5f/0x70 CPU: 1 PID: 21 Comm: ksoftirqd/1 Not tainted 5.14.0-rc7+ #32 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1 04/01/2014 RIP: 0010:j1939_session_deactivate+0x5f/0x70 Call Trace: j1939_session_deactivate_activate_next+0x11/0x28 j1939_xtp_rx_eoma+0x12a/0x180 j1939_tp_recv+0x4a2/0x510 j1939_can_recv+0x226/0x380 can_rcv_filter+0xf8/0x220 can_receive+0x102/0x220 ? process_backlog+0xf0/0x2c0 can_rcv+0x53/0xf0 __netif_receive_skb_one_core+0x67/0x90 ? process_backlog+0x97/0x2c0 __netif_receive_skb+0x22/0x80
References
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/1740a1e45eee65099a92fb502e1e67e63aad277d
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/6950df42a03c9ac9290503ced3f371199cb68fa9
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/9ab896775f98ff54b68512f345eed178bf961084
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/b6d44072117bba057d50f7a2f96e5d070c65926d
416baaa9-dc9f-4396-8d5f-8c081fb06d67https://git.kernel.org/stable/c/d0553680f94c49bbe0e39eb50d033ba563b4212d
Impacted products
Vendor Product Version
Linux Linux Version: 7eef18c0479ba5d9f54fba30cd77c233ebca3eb1
Version: 55dd22c5d029423f513fd849e633adf0e9c10d0c
Version: 0c71437dd50dd687c15d8ca80b3b68f10bb21d63
Version: 0c71437dd50dd687c15d8ca80b3b68f10bb21d63
Version: 0c71437dd50dd687c15d8ca80b3b68f10bb21d63
Version: 5e1fc537c1be332aef9621ca9146aeb3ba59522f
 Create a notification for this product.
   Linux Linux Version: 5.14
 Create a notification for this product.
Show details on NVD website

To clipboard 

{
  "containers": {
    "cna": {
      "affected": [
        {
          "defaultStatus": "unaffected",
          "product": "Linux",
          "programFiles": [
            "net/can/j1939/transport.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "lessThan": "6950df42a03c9ac9290503ced3f371199cb68fa9",
              "status": "affected",
              "version": "7eef18c0479ba5d9f54fba30cd77c233ebca3eb1",
              "versionType": "git"
            },
            {
              "lessThan": "b6d44072117bba057d50f7a2f96e5d070c65926d",
              "status": "affected",
              "version": "55dd22c5d029423f513fd849e633adf0e9c10d0c",
              "versionType": "git"
            },
            {
              "lessThan": "9ab896775f98ff54b68512f345eed178bf961084",
              "status": "affected",
              "version": "0c71437dd50dd687c15d8ca80b3b68f10bb21d63",
              "versionType": "git"
            },
            {
              "lessThan": "1740a1e45eee65099a92fb502e1e67e63aad277d",
              "status": "affected",
              "version": "0c71437dd50dd687c15d8ca80b3b68f10bb21d63",
              "versionType": "git"
            },
            {
              "lessThan": "d0553680f94c49bbe0e39eb50d033ba563b4212d",
              "status": "affected",
              "version": "0c71437dd50dd687c15d8ca80b3b68f10bb21d63",
              "versionType": "git"
            },
            {
              "status": "affected",
              "version": "5e1fc537c1be332aef9621ca9146aeb3ba59522f",
              "versionType": "git"
            }
          ]
        },
        {
          "defaultStatus": "affected",
          "product": "Linux",
          "programFiles": [
            "net/can/j1939/transport.c"
          ],
          "repo": "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git",
          "vendor": "Linux",
          "versions": [
            {
              "status": "affected",
              "version": "5.14"
            },
            {
              "lessThan": "5.14",
              "status": "unaffected",
              "version": "0",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "5.4.*",
              "status": "unaffected",
              "version": "5.4.232",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "5.10.*",
              "status": "unaffected",
              "version": "5.10.168",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "5.15.*",
              "status": "unaffected",
              "version": "5.15.93",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "6.1.*",
              "status": "unaffected",
              "version": "6.1.11",
              "versionType": "semver"
            },
            {
              "lessThanOrEqual": "*",
              "status": "unaffected",
              "version": "6.2",
              "versionType": "original_commit_for_fix"
            }
          ]
        }
      ],
      "cpeApplicability": [
        {
          "nodes": [
            {
              "cpeMatch": [
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "5.4.232",
                  "versionStartIncluding": "5.4.138",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "5.10.168",
                  "versionStartIncluding": "5.10.56",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "5.15.93",
                  "versionStartIncluding": "5.14",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.1.11",
                  "versionStartIncluding": "5.14",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionEndExcluding": "6.2",
                  "versionStartIncluding": "5.14",
                  "vulnerable": true
                },
                {
                  "criteria": "cpe:2.3:o:linux:linux_kernel:*:*:*:*:*:*:*:*",
                  "versionStartIncluding": "5.13.8",
                  "vulnerable": true
                }
              ],
              "negate": false,
              "operator": "OR"
            }
          ]
        }
      ],
      "descriptions": [
        {
          "lang": "en",
          "value": "In the Linux kernel, the following vulnerability has been resolved:\n\ncan: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate\n\nThe conclusion \"j1939_session_deactivate() should be called with a\nsession ref-count of at least 2\" is incorrect. In some concurrent\nscenarios, j1939_session_deactivate can be called with the session\nref-count less than 2. But there is not any problem because it\nwill check the session active state before session putting in\nj1939_session_deactivate_locked().\n\nHere is the concurrent scenario of the problem reported by syzbot\nand my reproduction log.\n\n        cpu0                            cpu1\n                                j1939_xtp_rx_eoma\nj1939_xtp_rx_abort_one\n                                j1939_session_get_by_addr [kref == 2]\nj1939_session_get_by_addr [kref == 3]\nj1939_session_deactivate [kref == 2]\nj1939_session_put [kref == 1]\n\t\t\t\tj1939_session_completed\n\t\t\t\tj1939_session_deactivate\n\t\t\t\tWARN_ON_ONCE(kref \u003c 2)\n\n=====================================================\nWARNING: CPU: 1 PID: 21 at net/can/j1939/transport.c:1088 j1939_session_deactivate+0x5f/0x70\nCPU: 1 PID: 21 Comm: ksoftirqd/1 Not tainted 5.14.0-rc7+ #32\nHardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1 04/01/2014\nRIP: 0010:j1939_session_deactivate+0x5f/0x70\nCall Trace:\n j1939_session_deactivate_activate_next+0x11/0x28\n j1939_xtp_rx_eoma+0x12a/0x180\n j1939_tp_recv+0x4a2/0x510\n j1939_can_recv+0x226/0x380\n can_rcv_filter+0xf8/0x220\n can_receive+0x102/0x220\n ? process_backlog+0xf0/0x2c0\n can_rcv+0x53/0xf0\n __netif_receive_skb_one_core+0x67/0x90\n ? process_backlog+0x97/0x2c0\n __netif_receive_skb+0x22/0x80"
        }
      ],
      "providerMetadata": {
        "dateUpdated": "2025-05-04T12:40:33.467Z",
        "orgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
        "shortName": "Linux"
      },
      "references": [
        {
          "url": "https://git.kernel.org/stable/c/6950df42a03c9ac9290503ced3f371199cb68fa9"
        },
        {
          "url": "https://git.kernel.org/stable/c/b6d44072117bba057d50f7a2f96e5d070c65926d"
        },
        {
          "url": "https://git.kernel.org/stable/c/9ab896775f98ff54b68512f345eed178bf961084"
        },
        {
          "url": "https://git.kernel.org/stable/c/1740a1e45eee65099a92fb502e1e67e63aad277d"
        },
        {
          "url": "https://git.kernel.org/stable/c/d0553680f94c49bbe0e39eb50d033ba563b4212d"
        }
      ],
      "title": "can: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate",
      "x_generator": {
        "engine": "bippy-1.2.0"
      }
    }
  },
  "cveMetadata": {
    "assignerOrgId": "416baaa9-dc9f-4396-8d5f-8c081fb06d67",
    "assignerShortName": "Linux",
    "cveId": "CVE-2021-4454",
    "datePublished": "2025-03-27T16:37:09.381Z",
    "dateReserved": "2025-02-26T02:29:43.631Z",
    "dateUpdated": "2025-05-04T12:40:33.467Z",
    "state": "PUBLISHED"
  },
  "dataType": "CVE_RECORD",
  "dataVersion": "5.1",
  "vulnerability-lookup:meta": {
    "nvd": "{\"cve\":{\"id\":\"CVE-2021-4454\",\"sourceIdentifier\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\",\"published\":\"2025-03-27T17:15:35.820\",\"lastModified\":\"2025-03-28T18:11:49.747\",\"vulnStatus\":\"Awaiting Analysis\",\"cveTags\":[],\"descriptions\":[{\"lang\":\"en\",\"value\":\"In the Linux kernel, the following vulnerability has been resolved:\\n\\ncan: j1939: fix errant WARN_ON_ONCE in j1939_session_deactivate\\n\\nThe conclusion \\\"j1939_session_deactivate() should be called with a\\nsession ref-count of at least 2\\\" is incorrect. In some concurrent\\nscenarios, j1939_session_deactivate can be called with the session\\nref-count less than 2. But there is not any problem because it\\nwill check the session active state before session putting in\\nj1939_session_deactivate_locked().\\n\\nHere is the concurrent scenario of the problem reported by syzbot\\nand my reproduction log.\\n\\n        cpu0                            cpu1\\n                                j1939_xtp_rx_eoma\\nj1939_xtp_rx_abort_one\\n                                j1939_session_get_by_addr [kref == 2]\\nj1939_session_get_by_addr [kref == 3]\\nj1939_session_deactivate [kref == 2]\\nj1939_session_put [kref == 1]\\n\\t\\t\\t\\tj1939_session_completed\\n\\t\\t\\t\\tj1939_session_deactivate\\n\\t\\t\\t\\tWARN_ON_ONCE(kref \u003c 2)\\n\\n=====================================================\\nWARNING: CPU: 1 PID: 21 at net/can/j1939/transport.c:1088 j1939_session_deactivate+0x5f/0x70\\nCPU: 1 PID: 21 Comm: ksoftirqd/1 Not tainted 5.14.0-rc7+ #32\\nHardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1 04/01/2014\\nRIP: 0010:j1939_session_deactivate+0x5f/0x70\\nCall Trace:\\n j1939_session_deactivate_activate_next+0x11/0x28\\n j1939_xtp_rx_eoma+0x12a/0x180\\n j1939_tp_recv+0x4a2/0x510\\n j1939_can_recv+0x226/0x380\\n can_rcv_filter+0xf8/0x220\\n can_receive+0x102/0x220\\n ? process_backlog+0xf0/0x2c0\\n can_rcv+0x53/0xf0\\n __netif_receive_skb_one_core+0x67/0x90\\n ? process_backlog+0x97/0x2c0\\n __netif_receive_skb+0x22/0x80\"}],\"metrics\":{},\"references\":[{\"url\":\"https://git.kernel.org/stable/c/1740a1e45eee65099a92fb502e1e67e63aad277d\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/6950df42a03c9ac9290503ced3f371199cb68fa9\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/9ab896775f98ff54b68512f345eed178bf961084\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/b6d44072117bba057d50f7a2f96e5d070c65926d\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"},{\"url\":\"https://git.kernel.org/stable/c/d0553680f94c49bbe0e39eb50d033ba563b4212d\",\"source\":\"416baaa9-dc9f-4396-8d5f-8c081fb06d67\"}]}}"
  }
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
  • Confirmed: The vulnerability is confirmed from an analyst perspective.
  • Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
  • Patched: This vulnerability was successfully patched by the user reporting the sighting.
  • Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
  • Not confirmed: The user expresses doubt about the veracity of the vulnerability.
  • Not patched: This vulnerability was not successfully patched by the user reporting the sighting.